Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for AWS Service Connections #149

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add Support for AWS Service Connections #149

wants to merge 6 commits into from

Conversation

zbuchheit
Copy link

Thank you for contributing! Before submitting your PR, can you please confirm that you have done the following?

  • If you changed the values of the properties name, publisher, and galleryFlags in the vss-extension.json file, you have reverted them.
  • If you changed the values of the properties id, name, author, you have reverted them.
  • I have reverted any changes to the version number components in both vss-extension.json and task.json, OR I didn't change them.

Related to: #80

justinvp
justinvp approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

In the future, you can just clone this repo directly and create a branch for the PR, rather than from your fork.

buildAndReleaseTask/awsServiceEndpoint.ts Show resolved Hide resolved
buildAndReleaseTask/models.d.ts Outdated Show resolved Hide resolved
buildAndReleaseTask/pulumi.ts Outdated Show resolved Hide resolved
@zbuchheit
Copy link
Author

LGTM otherwise

In the future, you can just clone this repo directly and create a branch for the PR, rather than from your fork.

I was following the Contributing doc but noted for next time! Thanks! Also, I noticed we do some integration testing, we will need to create an AWS service connection in the ADO org we run the test in if we want to add additional integration tests to cover this feature.

justinvp
justinvp approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also, I noticed we do some integration testing, we will need to create an AWS service connection in the ADO org we run the test in if we want to add additional integration tests to cover this feature

Yeah, it would be good to have a test, if it's easy to setup. Can you do that?

buildAndReleaseTask/awsServiceEndpoint.ts Outdated Show resolved Hide resolved
@zbuchheit
Copy link
Author

@justinvp I added the new awsServiceConnection input to the integration azure pipeline file on 137ddd7. Someone will need to add an aws service connection to the test organization in Azure Devops for the integration test to reference. I do not have access to that. The service connection is provided via the The AWS Toolkit for Azure Devops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zbuchheit @justinvp